go-trustlog/api/queryclient/client_additional_test.go

package queryclient_test

import (
	"context"
	"errors"
	"testing"

	"github.com/stretchr/testify/assert"
	"github.com/stretchr/testify/require"
	"google.golang.org/protobuf/types/known/timestamppb"

	"go.yandata.net/wangsiyuan/go-trustlog/api/grpc/pb"
	"go.yandata.net/wangsiyuan/go-trustlog/api/logger"
	"go.yandata.net/wangsiyuan/go-trustlog/api/model"
	"go.yandata.net/wangsiyuan/go-trustlog/api/queryclient"
)

// TestNewClient_ErrorCases 测试客户端创建的错误情况
func TestNewClient_ErrorCases(t *testing.T) {
	tests := []struct {
		name      string
		config    queryclient.ClientConfig
		wantError bool
	}{
		{
			name: "empty server addresses",
			config: queryclient.ClientConfig{
				ServerAddrs: []string{},
				ServerAddr:  "",
			},
			wantError: true,
		},
		{
			name: "invalid dial options",
			config: queryclient.ClientConfig{
				ServerAddr: "invalid://address",
			},
			wantError: false, // 连接错误在拨号时才会发生
		},
	}

	for _, tt := range tests {
		t.Run(tt.name, func(t *testing.T) {
			_, err := queryclient.NewClient(tt.config, logger.NewNopLogger())
			if tt.wantError {
				require.Error(t, err)
			} else {
				// 即使配置有问题，NewClient 也可能成功（连接是惰性的）
				t.Log("Client created, connection errors may occur on actual use")
			}
		})
	}
}

// TestListOperations_ErrorHandling 测试 ListOperations 的错误处理
func TestListOperations_ErrorHandling(t *testing.T) {
	// 由于需要实际的 gRPC 连接，这里主要测试输入验证
	t.Run("verify request construction", func(t *testing.T) {
		req := queryclient.ListOperationsRequest{
			PageSize:     10,
			OpSource:     "api",
			OpCode: model.OpCodeCreateID,
			DoPrefix:     "test",
			DoRepository: "repo",
		}

		assert.Equal(t, uint64(10), req.PageSize)
		assert.Equal(t, model.Source("api"), req.OpSource)
		assert.Equal(t, model.OpCodeCreateID, req.OpCode)
	})
}

// TestValidationRequest_Construction 测试 ValidationRequest 构造
func TestValidationRequest_Construction(t *testing.T) {
	req := queryclient.ValidationRequest{
		OpID:         "test-op",
		OpCode: model.OpCodeCreateID,
		DoRepository: "test-repo",
	}

	assert.Equal(t, "test-op", req.OpID)
	assert.Equal(t, model.OpCodeCreateID, req.OpCode)
	assert.Equal(t, "test-repo", req.DoRepository)
}

// TestListRecordsRequest_Construction 测试 ListRecordsRequest 构造
func TestListRecordsRequest_Construction(t *testing.T) {
	req := queryclient.ListRecordsRequest{
		PageSize: 20,
		DoPrefix: "test",
		RCType:   "log",
	}

	assert.Equal(t, uint64(20), req.PageSize)
	assert.Equal(t, "test", req.DoPrefix)
	assert.Equal(t, "log", req.RCType)
}

// TestRecordValidationRequest_Construction 测试 RecordValidationRequest 构造
func TestRecordValidationRequest_Construction(t *testing.T) {
	req := queryclient.RecordValidationRequest{
		RecordID: "rec-123",
		DoPrefix: "test",
		RCType:   "log",
	}

	assert.Equal(t, "rec-123", req.RecordID)
	assert.Equal(t, "test", req.DoPrefix)
	assert.Equal(t, "log", req.RCType)
}

// mockFailingOperationServer 总是失败的mock服务器
type mockFailingOperationServer struct {
	pb.UnimplementedOperationValidationServiceServer
}

func (s *mockFailingOperationServer) ListOperations(
	_ context.Context,
	_ *pb.ListOperationReq,
) (*pb.ListOperationRes, error) {
	return nil, errors.New("mock error: list operations failed")
}

func (s *mockFailingOperationServer) ValidateOperation(
	_ *pb.ValidationReq,
	stream pb.OperationValidationService_ValidateOperationServer,
) error {
	// 发送错误消息
	_ = stream.Send(&pb.ValidationStreamRes{
		Code: 500,
		Msg:  "Validation failed",
	})
	return errors.New("mock error: validation failed")
}

// mockFailingRecordServer 总是失败的mock记录服务器
type mockFailingRecordServer struct {
	pb.UnimplementedRecordValidationServiceServer
}

func (s *mockFailingRecordServer) ListRecords(
	_ context.Context,
	_ *pb.ListRecordReq,
) (*pb.ListRecordRes, error) {
	return nil, errors.New("mock error: list records failed")
}

func (s *mockFailingRecordServer) ValidateRecord(
	_ *pb.RecordValidationReq,
	stream pb.RecordValidationService_ValidateRecordServer,
) error {
	return errors.New("mock error: record validation failed")
}

// mockEmptyOperationServer 返回空数据的mock服务器
type mockEmptyOperationServer struct {
	pb.UnimplementedOperationValidationServiceServer
}

func (s *mockEmptyOperationServer) ListOperations(
	_ context.Context,
	_ *pb.ListOperationReq,
) (*pb.ListOperationRes, error) {
	return &pb.ListOperationRes{
		Count: 0,
		Data:  []*pb.OperationData{},
	}, nil
}

// mockInvalidDataOperationServer 返回无效数据的mock服务器
type mockInvalidDataOperationServer struct {
	pb.UnimplementedOperationValidationServiceServer
}

func (s *mockInvalidDataOperationServer) ListOperations(
	_ context.Context,
	_ *pb.ListOperationReq,
) (*pb.ListOperationRes, error) {
	return &pb.ListOperationRes{
		Count: 1,
		Data: []*pb.OperationData{
			{
				// 缺少必需的 Timestamp 字段
				OpId:     "invalid-op",
				OpSource: "test",
			},
		},
	}, nil
}

func (s *mockInvalidDataOperationServer) ValidateOperation(
	_ *pb.ValidationReq,
	stream pb.OperationValidationService_ValidateOperationServer,
) error {
	// 发送无效数据
	_ = stream.Send(&pb.ValidationStreamRes{
		Code:     200,
		Msg:      "Completed",
		Progress: "100%",
		Data: &pb.OperationData{
			// 缺少 Timestamp
			OpId: "invalid",
		},
	})
	return nil
}

// TestValidateOperationSync_ProgressCallback 测试带进度回调的同步验证
func TestValidateOperationSync_ProgressCallback(t *testing.T) {
	t.Run("verify progress callback structure", func(t *testing.T) {
		progressCalled := false
		progressCallback := func(result *model.ValidationResult) {
			progressCalled = true
			assert.NotNil(t, result)
		}

		// 验证回调函数签名正确
		assert.NotNil(t, progressCallback)
		
		// 模拟调用
		testResult := &model.ValidationResult{
			Code:     100,
			Msg:      "Processing",
			Progress: "50%",
		}
		progressCallback(testResult)
		assert.True(t, progressCalled)
	})
}

// TestValidateRecordSync_ProgressCallback 测试记录验证的进度回调
func TestValidateRecordSync_ProgressCallback(t *testing.T) {
	t.Run("verify record progress callback", func(t *testing.T) {
		called := false
		callback := func(result *model.RecordValidationResult) {
			called = true
			assert.NotNil(t, result)
		}

		testResult := &model.RecordValidationResult{
			Code:     100,
			Msg:      "Processing",
			Progress: "50%",
		}
		callback(testResult)
		assert.True(t, called)
	})
}

// TestClient_MultipleCallsToClose 测试多次调用 Close
func TestClient_MultipleCallsToClose(t *testing.T) {
	t.Skip("Requires actual gRPC setup")
	// 这个测试需要实际的 gRPC 连接来验证幂等性
}

// TestResponseConversion 测试响应转换逻辑
func TestResponseConversion(t *testing.T) {
	t.Run("operation response with nil timestamp", func(t *testing.T) {
		pbOp := &pb.OperationData{
		OpId:     "test",
		OpSource: "api",
		OpCode:   int32(model.OpCodeCreateID),
		// Timestamp: nil - 这应该导致转换失败
	}

		// 验证会失败因为缺少必需字段
		_, err := model.FromProtobuf(pbOp)
		assert.Error(t, err)
	})

	t.Run("operation response with valid data", func(t *testing.T) {
		pbOp := &pb.OperationData{
			OpId:      "test",
			OpSource:  "api",
			OpCode:    int32(model.OpCodeCreateID),
			Timestamp: timestamppb.Now(),
		}

		op, err := model.FromProtobuf(pbOp)
		require.NoError(t, err)
		assert.NotNil(t, op)
		assert.Equal(t, "test", op.OpID)
	})
}

// TestValidationResult_States 测试验证结果的状态
func TestValidationResult_States(t *testing.T) {
	tests := []struct {
		name        string
		result      *model.ValidationResult
		isCompleted bool
		isFailed    bool
	}{
		{
			name: "completed",
			result: &model.ValidationResult{
				Code: 200,
				Msg:  "Completed",
			},
			isCompleted: true,
			isFailed:    false,
		},
		{
			name: "failed",
			result: &model.ValidationResult{
				Code: 500,
				Msg:  "Failed",
			},
			isCompleted: false,
			isFailed:    true,
		},
		{
			name: "in progress",
			result: &model.ValidationResult{
				Code:     100,
				Msg:      "Processing",
				Progress: "50%",
			},
			isCompleted: false,
			isFailed:    false,
		},
	}

	for _, tt := range tests {
		t.Run(tt.name, func(t *testing.T) {
			assert.Equal(t, tt.isCompleted, tt.result.IsCompleted())
			assert.Equal(t, tt.isFailed, tt.result.IsFailed())
		})
	}
}

// TestRecordValidationResult_States 测试记录验证结果的状态
func TestRecordValidationResult_States(t *testing.T) {
	tests := []struct {
		name        string
		result      *model.RecordValidationResult
		isCompleted bool
		isFailed    bool
	}{
		{
			name: "completed",
			result: &model.RecordValidationResult{
				Code: 200,
				Msg:  "Completed",
			},
			isCompleted: true,
			isFailed:    false,
		},
		{
			name: "failed",
			result: &model.RecordValidationResult{
				Code: 500,
				Msg:  "Failed",
			},
			isCompleted: false,
			isFailed:    true,
		},
	}

	for _, tt := range tests {
		t.Run(tt.name, func(t *testing.T) {
			assert.Equal(t, tt.isCompleted, tt.result.IsCompleted())
			assert.Equal(t, tt.isFailed, tt.result.IsFailed())
		})
	}
}

// TestClient_GetLowLevel 测试获取底层客户端
func TestClient_GetLowLevel(t *testing.T) {
	t.Skip("Requires actual gRPC setup")
	// 需要实际的 gRPC 连接来测试 GetLowLevelOperationClient 和 GetLowLevelRecordClient
}

// TestListOperationsResponse_Structure 测试响应结构
func TestListOperationsResponse_Structure(t *testing.T) {
	resp := &queryclient.ListOperationsResponse{
		Count: 10,
		Data:  []*model.Operation{},
	}

	assert.Equal(t, int64(10), resp.Count)
	assert.NotNil(t, resp.Data)
	assert.Len(t, resp.Data, 0)
}

// TestListRecordsResponse_Structure 测试记录响应结构
func TestListRecordsResponse_Structure(t *testing.T) {
	resp := &queryclient.ListRecordsResponse{
		Count: 5,
		Data:  []*model.Record{},
	}

	assert.Equal(t, int64(5), resp.Count)
	assert.NotNil(t, resp.Data)
	assert.Len(t, resp.Data, 0)
}